Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make add to project workflow work on PRs #753

Merged
merged 10 commits into from
Oct 21, 2023
Merged

Make add to project workflow work on PRs #753

merged 10 commits into from
Oct 21, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Oct 21, 2023 •
edited
Loading

Fix the add to project workflow so that it works on PRs from forks, securely

example of testing: ASpoonPlaysGames#7

image
(i'll remove that PR from the project once this is merged/closed)

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 21, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

Note that this workflow won't work on this PR, since pull_request_target means that the workflow gets ran from the version of the file that the target branch has

GeckoEidechse
GeckoEidechse approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as far as I can tell this circumvents the previous issue by running it in the context of the target.

Kinda hard to test so we'll do it in prod :>

@GeckoEidechse GeckoEidechse merged commit 640d391 into R2Northstar:main Oct 21, 2023
3 checks passed
@ASpoonPlaysGames ASpoonPlaysGames mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ASpoonPlaysGames @GeckoEidechse